[RAC] Implementation of swapping thumbs in the slider#6532
Closed
novsource wants to merge 9 commits into
Closed
Conversation
novsource
changed the title
devongovett
force-pushed
the
main
branch
2 times, most recently
from
8cb1a5d to
3013156
Compare
devongovett
force-pushed
the
main
branch
2 times, most recently
from
a79adcf to
3013156
Compare
Member
|
Going to close this. The team discussed and decided not to support this behavior at this time. There are some behavioral and accessibility challenges here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes [#3387], [#6408]
Context
At the moment, the
Sliderimplementation does not allowthumbsto pass through each other (theSlideris in strict mode, as it were). However, many libraries allow you to do this (more information about this is written here #6408).This PR implements the ability for thumbs to pass through each other. In order to enable this additional feature, you need to pass a new
allowSwapprop to theSlider.In addition, this PR fixes the bug when the sliders got stuck in each other ([#3387], [#6408])
✅ Pull Request Checklist:
📝 Test Instructions:
Testing default behavior (no swap) with multiple thumbs
http://localhost:9003/?path=/story/slider-hooks--4-stacked-thumbs-with-disabled-swap&strict=true
With mouse
Disabled.Swap.-.Mouse.mov
WIth arrows
Disabled.Swap.Arrows.mov
With keys
Disabled.Swap.Keys.mov
Testing the swap of thumbs
http://localhost:9003/?path=/story/slider-hooks--4-stacked-thumbs-with-enabled-swap&providerSwitcher-express=false&strict=true
With mouse
Enabled.Swap.Mouse.mov
With arrows
Enabled.Swap.Arrows.mov
With keys
Enabled.Swap.Keys.mov
🧢 Your Project:
N/A